Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACs for correctly updating program benefits on a program update #2351

Closed
cdummett opened this issue Aug 21, 2024 · 0 comments · Fixed by #2363
Closed

Add ACs for correctly updating program benefits on a program update #2351

cdummett opened this issue Aug 21, 2024 · 0 comments · Fixed by #2363

Comments

@cdummett
Copy link
Collaborator

Background

In core currently there is a bug where if a program is enacted in epoch K, the program is correctly updated in K + 1 but benefit factors aren't updated un till K + 2.

ACs did not capture the issue as tests simply checked if the program was correctly updated which it was rather than checking the benefits.

Summary

Check specs are clear on behaviour and add acceptance criteria to test...

  • if a program is updated in epoch K, in epoch K + 1, the program is FIRST updated and then factors are ALSO set using updated benefits.
    • referral program
    • volume discount program
    • volume rebate program

Everything should now happen when an engine is notified of the start of the epoch rather then the end, as such tests checking look back windows should be verified for changes to check we are not off by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants