Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tidy up the features.json for palazzo milestone #2030

Merged
merged 5 commits into from
Nov 2, 2023
Merged

chore: tidy up the features.json for palazzo milestone #2030

merged 5 commits into from
Nov 2, 2023

Conversation

gordsport
Copy link
Contributor

@gordsport gordsport commented Nov 2, 2023 •
edited
Loading

This archives off the cosmic features.json file and tidies up current one ready for the addition of more palazzo ACs

  • The tidied features.json file will be used with this PR to get metrics on coverage
  • the cosmic-features.json is purely a record of what was there at this time. It could be removed when we are sure that we do not need the information

@gordsport
chore: tidy up the features.json for palazzo milestone
70bdb58 
This archives off the cosmic features.json file and tidies up current one ready for the addition of more palazzo ACs
@gordsport gordsport self-assigned this Nov 2, 2023
@gordsport gordsport added this to the 🏰 Palazzo Mistero milestone Nov 2, 2023
cdummett
cdummett reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@cdummett cdummett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments re features which were deferred / disabled / not implemented for cosmic.

protocol/cosmic-features.json Show resolved Hide resolved
protocol/cosmic-features.json Show resolved Hide resolved
protocol/cosmic-features.json Show resolved Hide resolved
@gordsport gordsport requested a review from cdummett November 2, 2023 15:46
@gordsport gordsport merged commit 665e2b2 into palazzo Nov 2, 2023
4 checks passed
@gordsport gordsport deleted the add-ACs-to-features-for-palazzo branch November 2, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdummett cdummett cdummett approved these changes

@davidsiska-vega davidsiska-vega Awaiting requested review from davidsiska-vega

Assignees

@gordsport gordsport

Labels
ac-code-remediation
Projects
None yet
Milestone
🏰 Palazzo Mistero
Development

Successfully merging this pull request may close these issues.
2 participants
@gordsport @cdummett