Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ac isolated margin #2054

Merged
merged 9 commits into from
Nov 15, 2023
Merged

Ac isolated margin #2054

merged 9 commits into from
Nov 15, 2023

Conversation

Jiajia-Cui
Copy link
Contributor

closes #2029

@Jiajia-Cui Jiajia-Cui self-assigned this Nov 10, 2023
@Jiajia-Cui Jiajia-Cui changed the base branch from master to palazzo November 10, 2023 11:32
TomMcL
TomMcL suggested changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@TomMcL TomMcL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the first set of Acs could do with specific examples of what should happen/numbers the balances should be, and maybe a couple about changing the level of leverage/switching mode entirely would be good?

protocol/0019-MCAL-margin_calculator.md Outdated Show resolved Hide resolved
protocol/0019-MCAL-margin_calculator.md Outdated Show resolved Hide resolved
@gordsport gordsport requested a review from ze97286 November 13, 2023 09:45
@Jiajia-Cui Jiajia-Cui requested a review from TomMcL November 14, 2023 17:40
@Jiajia-Cui Jiajia-Cui merged commit f759388 into palazzo Nov 15, 2023
4 checks passed
@Jiajia-Cui Jiajia-Cui deleted the ac-isolated-margin branch November 15, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomMcL TomMcL TomMcL approved these changes

@ze97286 ze97286 Awaiting requested review from ze97286

Assignees

@Jiajia-Cui Jiajia-Cui

Labels
ac-code-remediation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add margin isolation acceptance criteria
2 participants
@Jiajia-Cui @TomMcL