Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding market flags proposal spec #2103

Merged
merged 11 commits into from
Jan 10, 2024
Merged

feat: Adding market flags proposal spec #2103

merged 11 commits into from
Jan 10, 2024

Conversation

TomMcL
Copy link
Contributor

@TomMcL TomMcL commented Jan 9, 2024 •
edited
Loading

Closes #2101

@TomMcL TomMcL requested a review from a team January 9, 2024 13:07
@TomMcL TomMcL self-assigned this Jan 9, 2024
davidsiska-vega
davidsiska-vega reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@davidsiska-vega davidsiska-vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be good to add a mention of this into batch proposals too i.e. this can be included within a batch.

@TomMcL TomMcL requested a review from davidsiska-vega January 9, 2024 15:27
@TomMcL TomMcL marked this pull request as ready for review January 9, 2024 15:49
davidsiska-vega
davidsiska-vega reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@davidsiska-vega davidsiska-vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One flags -> tags seems to have escaped.

protocol/0001-MKTF-market_framework.md Outdated Show resolved Hide resolved
davidsiska-vega
davidsiska-vega previously approved these changes Jan 9, 2024
View reviewed changes
@TomMcL TomMcL added this to the 🌌 Nebula milestone Jan 9, 2024
@gordsport gordsport linked an issue Jan 10, 2024 that may be closed by this pull request
Add specification for governance proposal to add flags to a market #2101
Closed
@TomMcL TomMcL merged commit f04ac1c into nebula Jan 10, 2024
4 checks passed
@TomMcL TomMcL deleted the feat/market_flags branch January 10, 2024 12:30
@TomMcL TomMcL restored the feat/market_flags branch January 10, 2024 12:30
@TomMcL TomMcL deleted the feat/market_flags branch January 10, 2024 12:30
gordsport added a commit that referenced this pull request Jan 16, 2024
@TomMcL @gordsport
feat: Adding market tags proposal spec (#2103)
783ed70 
---------

Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com>
gordsport added a commit that referenced this pull request Jan 23, 2024
@TomMcL @gordsport
feat: Adding market tags proposal spec (#2103)
383856c 
---------

Co-authored-by: Gordsport <83510148+gordsport@users.noreply.github.com>
@gordsport gordsport mentioned this pull request Jan 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsiska-vega davidsiska-vega davidsiska-vega approved these changes

Assignees

@TomMcL TomMcL

Labels
None yet
Projects
None yet
Milestone
🏛️ Colosseo I
Development

Successfully merging this pull request may close these issues.

Add specification for governance proposal to add flags to a market
3 participants
@TomMcL @davidsiska-vega @gordsport