Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify margin calculation (remove order book slippage) #2167

Merged
merged 4 commits into from
Feb 9, 2024
Merged

feat: simplify margin calculation (remove order book slippage) #2167

merged 4 commits into from
Feb 9, 2024

Conversation

Jiajia-Cui
Copy link
Contributor

closes #2081

@Jiajia-Cui Jiajia-Cui self-assigned this Feb 8, 2024
@gordsport gordsport added this to the 🏛️ Colosseo milestone Feb 8, 2024
@gordsport gordsport requested a review from wwestgarth February 8, 2024 16:27
@davidsiska-vega davidsiska-vega marked this pull request as draft February 8, 2024 16:53
@Jiajia-Cui Jiajia-Cui changed the title feat: update margin slippage in AMM feat: simplify margin calculation Feb 8, 2024
@Jiajia-Cui Jiajia-Cui changed the title feat: simplify margin calculation feat: simplify margin calculation (remove order book slippage) Feb 8, 2024
@Jiajia-Cui Jiajia-Cui marked this pull request as ready for review February 9, 2024 14:05
witgaw
witgaw approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@witgaw witgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jiajia-Cui Jiajia-Cui merged commit 0d55280 into colosseo Feb 9, 2024
4 checks passed
@Jiajia-Cui Jiajia-Cui deleted the AMM-margin-calc branch February 9, 2024 16:35
@gordsport gordsport mentioned this pull request Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@witgaw witgaw witgaw approved these changes

@wwestgarth wwestgarth Awaiting requested review from wwestgarth

Assignees

@Jiajia-Cui Jiajia-Cui

Labels
None yet
Projects
None yet
Milestone
🏛️ Colosseo I
Development

Successfully merging this pull request may close these issues.
3 participants
@Jiajia-Cui @witgaw @gordsport