Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update spot spec with palazzo and colosseo features #2219

Merged
merged 15 commits into from
Mar 25, 2024

Conversation

cdummett
Copy link
Collaborator

@cdummett cdummett commented Mar 22, 2024

closes #2155

PR aligns specs which touch the Spot product for core changes made in palazzo and colosseo.

It also adds ACs to cover untested components of spot markets.

  • 0041-TSTK:
    • New ACs added to ensure target stake calculated correctly in spot markets.
  • 0042-LIQF:
    • Spot specific ACs added to ensure marginal cost mechanisms works when new LPs join/leave markets (lower priority as this is extensively tested for future and perpetuals).
    • Spot specific ACs added to ensure fixed fee works.
    • Spot specific ACs added to ensure weighted cost works.
    • Spot specific ACs added to ensure time on book calculated correctly.
    • Spot specific ACs added to ensure fees distributed correctly (lower priority as this is extensively tested for future and perpetuals).
  • 0044-LIQM:
    • Spot specific ACs added to ensure liquidity commitments and early exit amendments are calculated correctly.
  • 0014-ORDT:
    • Spot specific ACs added for stop orders.

@cdummett cdummett added the spot label Mar 22, 2024
@cdummett cdummett added this to the 🏛️ Colosseo milestone Mar 22, 2024
@cdummett cdummett self-assigned this Mar 22, 2024
@cdummett cdummett changed the base branch from master to colosseo March 22, 2024 11:35
@cdummett cdummett force-pushed the feat/updates_for_spot branch 6 times, most recently from 4def1a9 to 7b6ca7b Compare March 22, 2024 15:53
@cdummett cdummett force-pushed the feat/updates_for_spot branch from 7b6ca7b to a7f4bc9 Compare March 25, 2024 10:23
@cdummett cdummett marked this pull request as ready for review March 25, 2024 10:24
Co-authored-by: Jiajia-Cui <92106936+Jiajia-Cui@users.noreply.github.com>
@cdummett cdummett requested a review from Jiajia-Cui March 25, 2024 15:01
Jiajia-Cui
Jiajia-Cui previously approved these changes Mar 25, 2024
@gordsport gordsport requested a review from Jiajia-Cui March 25, 2024 18:30
@Jiajia-Cui Jiajia-Cui merged commit a954635 into colosseo Mar 25, 2024
4 checks passed
@Jiajia-Cui Jiajia-Cui deleted the feat/updates_for_spot branch March 25, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Update spot spec with Palazzo features
3 participants