Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LP performance reward metric #2266

Closed
wants to merge 6 commits into from
Closed

Conversation

cdummett
Copy link
Collaborator

@cdummett cdummett commented May 8, 2024

Warning

Changes in this PR will be superseded by changes from the liquidity mechanisms overhaul #2299 and #2309. This PR should only be merged and work ticketed if need for improved liquidity rewards cannot be delayed to genbutemple.

Summary

PR adds a new reward metric for reward Liquidity Providers for providing liquidity within a specified range.

To make the rewards independent of the liquidity fees accumulated on a market, the transfer implements the concept of "virtual fees". That is, the fees that would have been distributed for a fixed amount of accumulated fees (1 quantum).

This reward metric will require core to compute SLA performance for a number of price ranges and as such a new network parameter is added to restrict the minimum transfer size of transfers to reward pools.

@cdummett cdummett added this to the 🏛️ Colosseo II milestone May 8, 2024
@cdummett cdummett self-assigned this May 8, 2024
@cdummett cdummett changed the base branch from master to colosseo_II May 8, 2024 09:45
@cdummett cdummett marked this pull request as ready for review May 15, 2024 09:57
@cdummett cdummett requested a review from a team May 15, 2024 09:57
@cdummett cdummett force-pushed the feat/sla-rewards branch from 0c18b52 to baa233a Compare May 20, 2024 11:21
protocol/0056-REWA-rewards_overview.md Outdated Show resolved Hide resolved
protocol/0056-REWA-rewards_overview.md Outdated Show resolved Hide resolved
@cdummett cdummett force-pushed the feat/sla-rewards branch 2 times, most recently from a17c91c to 10d724c Compare June 4, 2024 14:18
@davidsiska-vega
Copy link
Contributor

Blocked until we finalise #2299

@davidsiska-vega davidsiska-vega marked this pull request as draft June 19, 2024 10:09
@cdummett cdummett force-pushed the feat/sla-rewards branch 2 times, most recently from 30ddc89 to cb73553 Compare June 24, 2024 12:47
@witgaw
Copy link
Contributor

witgaw commented Jul 8, 2024

#2299 has been merged now, but lets leave this one open until the work's been prioritised.

@cdummett
Copy link
Collaborator Author

Closing PR as ticket closed - #2305

@cdummett cdummett closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants