-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LP performance reward metric #2266
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdummett
force-pushed
the
feat/sla-rewards
branch
from
May 20, 2024 11:21
0c18b52
to
baa233a
Compare
TomMcL
reviewed
May 20, 2024
cdummett
force-pushed
the
feat/sla-rewards
branch
2 times, most recently
from
June 4, 2024 14:18
a17c91c
to
10d724c
Compare
Blocked until we finalise #2299 |
cdummett
force-pushed
the
feat/sla-rewards
branch
2 times, most recently
from
June 24, 2024 12:47
30ddc89
to
cb73553
Compare
cdummett
force-pushed
the
feat/sla-rewards
branch
from
June 24, 2024 12:52
cb73553
to
03a135e
Compare
#2299 has been merged now, but lets leave this one open until the work's been prioritised. |
Closing PR as ticket closed - #2305 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Changes in this PR will be superseded by changes from the liquidity mechanisms overhaul #2299 and #2309. This PR should only be merged and work ticketed if need for improved liquidity rewards cannot be delayed to
genbutemple
.Summary
PR adds a new reward metric for reward Liquidity Providers for providing liquidity within a specified range.
To make the rewards independent of the liquidity fees accumulated on a market, the transfer implements the concept of "virtual fees". That is, the fees that would have been distributed for a fixed amount of accumulated fees (1 quantum).
This reward metric will require core to compute SLA performance for a number of price ranges and as such a new network parameter is added to restrict the minimum transfer size of transfers to reward pools.