New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec for governance token staking from general account and locked rewards counting towards staking balance #2350

Merged

Jiajia-Cui merged 19 commits into suzukacastle_II from Governance-token-staking-from-general-account

Aug 23, 2024

Contributor

Jiajia-Cui commented Aug 20, 2024 •

edited

Loading

closes #2347

Jiajia-Cui changed the title ~~feat: update 0057~~ Add spec for governance token staking from general account and locked rewards counting towards staking balance

Jiajia-Cui marked this pull request as ready for review

August 20, 2024 14:28

davidsiska-vega reviewed

View reviewed changes

protocol/0013-ACCT-accounts.md Outdated Show resolved Hide resolved

davidsiska-vega reviewed

View reviewed changes

protocol/0057-TRAN-transfers.md Outdated Show resolved Hide resolved

davidsiska-vega reviewed

View reviewed changes

protocol/0057-TRAN-transfers.md Outdated Show resolved Hide resolved

davidsiska-vega reviewed

View reviewed changes

protocol/0057-TRAN-transfers.md Outdated Show resolved Hide resolved

davidsiska-vega reviewed

View reviewed changes

protocol/0059-STKG-simple_staking_and_delegating.md Outdated Show resolved Hide resolved

davidsiska-vega requested changes

View reviewed changes

Contributor

davidsiska-vega left a comment

We need more detail around staking locked rewards.

davidsiska-vega reviewed

View reviewed changes

protocol/0013-ACCT-accounts.md Outdated Show resolved Hide resolved

davidsiska-vega reviewed

View reviewed changes

protocol/0057-TRAN-transfers.md Outdated Show resolved Hide resolved

davidsiska-vega reviewed

View reviewed changes

protocol/0059-STKG-simple_staking_and_delegating.md Outdated Show resolved Hide resolved

davidsiska-vega reviewed

View reviewed changes

protocol/0013-ACCT-accounts.md Outdated Show resolved Hide resolved

davidsiska-vega reviewed

View reviewed changes

protocol/0013-ACCT-accounts.md Show resolved Hide resolved

davidsiska-vega previously requested changes

View reviewed changes

Contributor

davidsiska-vega left a comment

more changes discussed

davidsiska-vega reviewed

View reviewed changes

protocol/0056-REWA-rewards_overview.md Outdated Show resolved Hide resolved

davidsiska-vega reviewed

View reviewed changes

protocol/0056-REWA-rewards_overview.md Outdated Show resolved Hide resolved

davidsiska-vega reviewed

View reviewed changes

protocol/0056-REWA-rewards_overview.md Outdated Show resolved Hide resolved

davidsiska-vega reviewed

View reviewed changes

protocol/0059-STKG-simple_staking_and_delegating.md Outdated Show resolved Hide resolved

Jiajia-Cui requested a review from davidsiska-vega

August 21, 2024 15:47

davidsiska-vega changed the base branch from suzukacastle to suzukacastle_II

August 22, 2024 10:14

jeremyletang reviewed

View reviewed changes

protocol/0013-ACCT-accounts.md Outdated Show resolved Hide resolved

cdummett requested changes

View reviewed changes

protocol/0056-REWA-rewards_overview.md Outdated Show resolved Hide resolved

protocol/0056-REWA-rewards_overview.md Outdated Show resolved Hide resolved

protocol/0056-REWA-rewards_overview.md Outdated Show resolved Hide resolved

protocol/0057-TRAN-transfers.md Show resolved Hide resolved

Jiajia-Cui requested a review from cdummett

August 22, 2024 14:56

Jiajia-Cui self-assigned this

Jiajia-Cui added 6 commits

August 23, 2024 10:28


          feat: update 0057

8792ed6


          feat: update 0059

0b20575


          feat: update 0013

8dbe014


          chore: mark down

b308a27


          feat: address comments

886b783


          feat: address comments

cb6a46c

Jiajia-Cui and others added 9 commits

August 23, 2024 10:28


          chore: markdown

e9fde26


          feat: address comments

84b3952

Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com>


          feat: address comments

d89fd66

Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com>


          feat: address comments

5512fe3

Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com>


          feat: address comments

f09c963

Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com>


          feat: address comments

e3b6c24


          feat: address comments

303bc8d


          chore: spelling

600a90d


          chore: markdown

2afc227

Jiajia-Cui force-pushed the Governance-token-staking-from-general-account branch from 6f67464 to 2afc227 Compare

August 23, 2024 09:28


          feat: update AC code

1ad936e

cdummett requested changes

View reviewed changes

protocol/0057-TRAN-transfers.md Show resolved Hide resolved

protocol/features.json Outdated Show resolved Hide resolved

Jiajia-Cui added 3 commits

August 23, 2024 11:12


          feat: update json file

27e6798


          feat: add vested account

ec2bc29


          chore: tidy up

3d0e0d6

cdummett approved these changes

View reviewed changes

Jiajia-Cui dismissed davidsiska-vega’s stale review

August 23, 2024 11:02

address comments

Jiajia-Cui merged commit fe7363e into suzukacastle_II

4 checks passed

Jiajia-Cui deleted the Governance-token-staking-from-general-account branch

August 23, 2024 11:09

davidsiska-vega mentioned this pull request

Governance token staking from general account and locked rewards counting towards staking balance #2347

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet