-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allowed empty AMM levels #2358
Draft
cdummett
wants to merge
5
commits into
suzukacastle_II
Choose a base branch
from
feat/empty_amm_levels
base: suzukacastle_II
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdummett
force-pushed
the
feat/empty_amm_levels
branch
from
September 10, 2024 10:16
7246759
to
4d6a294
Compare
cdummett
force-pushed
the
feat/empty_amm_levels
branch
from
September 10, 2024 10:25
4d6a294
to
705a118
Compare
feat: apply refactor feedback Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com>
$$ | ||
|
||
$$ | ||
n\cdot\Delta{p} \geq {p_u} - (\frac{L\cdot\sqrt{p_u}}{L + \Delta{P}\cdot \sqrt{p_u}})^2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
n\cdot\Delta{p} \geq {p_u} - (\frac{L\cdot\sqrt{p_u}}{L + \Delta{P}\cdot \sqrt{p_u}})^2 | |
n\cdot\Delta{p} \geq {p_u} - \bigg(\frac{L\cdot\sqrt{p_u}}{L + \Delta{P}\cdot \sqrt{p_u}}\bigg)^2 |
$$ | ||
n\cdot\Delta{p} \geq (p_u - p_{bb}) | ||
$$ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
this is equivalent to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently core rejects any AMM pool which does not provide at least one unit of volume between every tick in the AMM's range. PR updates spec with a new market parameter$allowedEmptyAmmLevels$ which defines the maximum size of a range in which an AMM is allowed to quote no volume. This range is measured in ticks.
As a guide of what this change means for mainnet markets, the below plot shows the value$allowedEmptyAmmLevels$ should be set to for the smallest commitment to be valid when the specific parameters are selected.
e.g. to allow$leverageAtLowerBounds=5$ for a $lowerBound$ offset 2% from the $basePrice$ , $allowedEmptyAmmLevels\geq1600$
The PR also gives equations for calculating the best-bid / best-ask to avoid core iterating over the range to find the price at which an AMM provides at least one unit of volume.
Notes