Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add flag to determine behaviour on failure of a nested instruction #2362

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

witgaw
Copy link
Contributor

@witgaw witgaw commented Sep 16, 2024

Closes #2355

@witgaw witgaw added this to the 🕌 Genbu Temple milestone Sep 16, 2024
@witgaw witgaw self-assigned this Sep 16, 2024
@witgaw witgaw force-pushed the 2355 branch 2 times, most recently from f99b121 to 837cfc8 Compare September 16, 2024 10:11
Copy link
Contributor

@davidsiska-vega davidsiska-vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I had in mind; let's add some ACs and call this good.

Copy link
Member

@barnabee barnabee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One clarification needed then this is good

Co-authored-by: David Siska <62546419+davidsiska-vega@users.noreply.github.com>
@witgaw witgaw merged commit 6fd5498 into genbutemple Sep 18, 2024
4 checks passed
@witgaw witgaw deleted the 2355 branch September 18, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants