Check candles in marketHash #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some nodes on some networks have empty candles for some date ranges. While the cause isn't known, the effect is that
those nodes are unsuitable for console usage. To track this, candles are now requested on the marketsConnection part
of the query and included in the markets hash.
Nodes are now more likely to differ on marketHash, but this difference has an impact so it's worth tracking.
Currently the value defaults to 36 1 hour candles. This is a high enough value that it is meaningful, but low enough that
no nodes that are currently checked change status.