fix: publish market updates on restart from 73.1

Signed-off-by: Jeremy Letang <me@jeremyletang.com>
vegaprotocol · Nov 1, 2023 · 53b2b19 · 53b2b19
1 parent 8866cf2
commit 53b2b19
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/core/execution/future/market.go b/core/execution/future/market.go
@@ -165,6 +165,8 @@ type Market struct {
 	// are applied properly
 	ensuredMigration73 bool
 	epoch              types.Epoch
+
+	publishMarketOnRestart bool
 }
 
 // NewMarket creates a new market using the market framework configuration and creates underlying engines.
@@ -433,6 +435,10 @@ func (m *Market) onEpochEndPartiesStats() {
 }
 
 func (m *Market) BeginBlock(ctx context.Context) {
+	if m.publishMarketOnRestart {
+		m.broker.Send(events.NewMarketUpdatedEvent(ctx, *m.mkt))
+		m.publishMarketOnRestart = false
+	}
 	if m.ensuredMigration73 {
 		return
 	}

diff --git a/core/execution/future/market_snapshot.go b/core/execution/future/market_snapshot.go
@@ -39,6 +39,7 @@ import (
 	"code.vegaprotocol.io/vega/core/risk"
 	"code.vegaprotocol.io/vega/core/settlement"
 	"code.vegaprotocol.io/vega/core/types"
+	vgcontext "code.vegaprotocol.io/vega/libs/context"
 	"code.vegaprotocol.io/vega/libs/num"
 	"code.vegaprotocol.io/vega/libs/ptr"
 	"code.vegaprotocol.io/vega/logging"
@@ -172,6 +173,11 @@ func NewMarketFromSnapshot(
 		expiringStopOrders = common.NewExpiringOrdersFromState(em.ExpiringStopOrders)
 	}
 
+	var publishMarket bool
+	if vgcontext.InProgressUpgradeFrom(ctx, "v0.73.1") {
+		publishMarket = true
+	}
+
 	now := timeService.GetTimeNow()
 	marketType := mkt.MarketType()
 	market := &Market{
@@ -218,6 +224,7 @@ func NewMarketFromSnapshot(
 		stopOrders:                    stopOrders,
 		expiringStopOrders:            expiringStopOrders,
 		perp:                          marketType == types.MarketTypePerp,
+		publishMarketOnRestart:        publishMarket,
 	}
 
 	for _, p := range em.Parties {

diff --git a/core/netparams/snapshot.go b/core/netparams/snapshot.go
@@ -138,10 +138,6 @@ func (s *Store) LoadState(ctx context.Context, pl *types.Payload) ([]types.State
 				Key:   "governance.proposal.transfer.minVoterBalance",
 				Value: "1000000000000000000",
 			},
-			{
-				Key:   "governance.proposal.transfer.minVoterBalance",
-				Value: "1000000000000000000",
-			},
 			{
 				Key:   "governance.proposal.transfer.requiredParticipation",
 				Value: "0.01",