Merge pull request #10481 from vegaprotocol/fix_pos_migration

fix: migrate average entry price to zero if position

CHANGELOG.md

@@ -151,6 +151,7 @@
 - [10434](https://github.com/vegaprotocol/vega/issues/10434) - Unsubscribe oracles when market is closed.
 - [10454](https://github.com/vegaprotocol/vega/issues/10454) - Fix account resolver validation to include order margin account.
 - [10451](https://github.com/vegaprotocol/vega/issues/10451) - Fix get update asset bundle.
+- [10480](https://github.com/vegaprotocol/vega/issues/10480) - Fix migration of position average entry price.
 - [10419](https://github.com/vegaprotocol/vega/issues/10419) - Block explorer database migration is slow.
 - [10431](https://github.com/vegaprotocol/vega/issues/10431) - Fix source staleness validation.
 - [10419](https://github.com/vegaprotocol/vega/issues/10419) - Block explorer database migration is slow.

core/positions/snapshot.go

@@ -20,6 +20,7 @@ import (
 	"sort"
 
 	"code.vegaprotocol.io/vega/core/types"
+	"code.vegaprotocol.io/vega/libs/num"
 	"code.vegaprotocol.io/vega/libs/proto"
 	"code.vegaprotocol.io/vega/libs/ptr"
 	"code.vegaprotocol.io/vega/logging"
@@ -104,8 +105,12 @@ func (e *SnapshotEngine) LoadState(_ context.Context, payload *types.Payload) ([
 
 			// This is for migration, on the first time we load from snapshot there won't be an average entry price
 			// so take the last price as the current average
-			if (p.AverageEntryPrice == nil || p.AverageEntryPrice.IsZero()) && pos.size != 0 && !pos.price.IsZero() {
-				pos.averageEntryPrice = pos.price.Clone()
+			if p.AverageEntryPrice == nil {
+				if pos.size != 0 && !pos.price.IsZero() {
+					pos.averageEntryPrice = pos.price.Clone()
+				} else {
+					pos.averageEntryPrice = num.UintZero()
+				}
 			}
 
 			// ensure these exists on the first snapshot after the upgrade