Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment growth issues #35

Open
Others opened this issue Mar 9, 2020 · 0 comments
Open

Fix deployment growth issues #35

Others opened this issue Mar 9, 2020 · 0 comments

Comments

@Others
Copy link
Contributor

Others commented Mar 9, 2020

The subtle bug is the following:

Timmy deploys a component from his repo timmysGreatComponent
Timmy pushes a commit to his dev branch
The deployment manager sees it should deploy (since there is a new push event)
There are now two workers running identical versions of the component
This situation remains until there is a push to master
(so we could end up with timmy's component on every worker)
I think this means we need to be cleverer about push events -- make sure they come from the right branch or stop using the HEAD trick. We also could just clean up this situation in the auto scaling stack, but that seems inelegant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant