Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Handler is racey, should switch to using queue for each repo #8

Open
hjaensch7 opened this issue Dec 18, 2019 · 2 comments
Open
Assignees

Comments

@hjaensch7
Copy link
Contributor

hjaensch7 commented Dec 18, 2019

The temporary repositories should be unique to avoid races when this queue is implemented.

@hjaensch7
Copy link
Contributor Author

this also impacts the responses provided to github, should start go routine and return 200 ok

@hjaensch7 hjaensch7 assigned hjaensch7 and Others and unassigned hjaensch7 Feb 11, 2020
@hjaensch7
Copy link
Contributor Author

Instead of crashing on this race condition subsequent pushes that happen during deployment will be ignored. These pushes should be queued and checked against the hash of the deployed component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants