Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

an apostrophe can modify results #18

Open
Fil opened this issue Jan 18, 2018 · 3 comments
Open

an apostrophe can modify results #18

Fil opened this issue Jan 18, 2018 · 3 comments

Comments

@Fil
Copy link

Fil commented Jan 18, 2018

I was looking to geocode a file that contained "Villeneuve d'Ascq, France", and the script found "Strada Villeneuve D' Asq, Gorj, Romania".

For some reason the apostrophe was encoded to an HTML numeric entity and caused this problem and the death of many squirrels 🐿.

I fixed it for this specific case with

url = url.replace(/'/, " ");

but maybe mustache has an option for removing html codes or transcoding them properly to utf8.

I can send a PR if you like, but I'm not sure of he scope of the problem or the best way to fix it.

@veltman
Copy link
Owner

veltman commented Jan 18, 2018

Thanks for the report! I probably won't get to it for a while but I'll definitely take a look.

@fthues
Copy link

fthues commented Aug 4, 2020

Same here, apostrophe breaks the request:

Cho d'Punt 34",081 850 02 56,...,
REQUEST_DENIED: You must use an API key to authenticate each request to Google Maps Platform APIs. For additional information, please refer to http://g.co/dev/maps-no-account```

@cascafico
Copy link

cascafico commented Sep 23, 2020

I confirm: no way to have it geocoded when place contains an apostrophe.
I'm using with Nominatim url , osm handler.
Verbose echoes "ERROR PARSING RESPONSE:
and a long html from Nominatim

8 out of 330 rows are not geocoded: these places have an apostrophe in common.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants