Fixes scrollView.contentSize resizing #21
Conversation
| @@ -187,6 +179,32 @@ - (NSString *)inputText | |||
|
|
|||
| #pragma mark - View Layout | |||
|
|
|||
| - (void)layoutSubviews { | |||
There was a problem hiding this comment.
To be consistent with our style:
- (void)layoutSubviews
{
[super layoutSubviews];
[self commitLayoutSubviews];
}
|
Thank you for this pull-request! I've left some preliminary style comments. I'll play around with the functionality. |
|
Sorry for code style, recently I started to use __ for private methods and I really like it. But since this is your code I'll adjust to your code style :) Btw do I need to make code changes or will you make them? |
|
It would be great if you could make them. 😄 |
ayanonagon
force-pushed
the
master
branch
2 times, most recently
from
19b4b61
to
a0495aa
Compare
|
Sorry for delay in responding, done! :) |
|
Can you let me know will you merge this request or should I make subclass in my app to fix this issue? Thanks |
|
Hi @josipbernat, sorry for the delay. Can you fix the curly brace style for - (void)commitLayoutSubviews {to - (void)commitLayoutSubviews
{and remove the newline after Sorry for nitpicking, and thanks again for the PR. |
|
Sorry for delay in responding. Changed and pushed :) |
|
Thanks for the updates! It looks like the Travis build failed for some reason (weird because all you changed is code style in the last commit). I'll take a look at the stack trace as well. 👍 |
When view was dynamically resized, scrollView.contentSize stayed the same. Because of that tokens had wrong layout.