Fixed bug where screen would 'bounce' when presenting in a modal dialog ... #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…og on iPad with soft keyboard active in landscape.
| @@ -183,7 +183,11 @@ - (void)layoutTokensAndInputWithFrameAdjustment:(BOOL)shouldAdjustFrame | |||
| { | |||
| [self.collapsedLabel removeFromSuperview]; | |||
| BOOL inputFieldShouldBecomeFirstResponder = self.inputTextField.isFirstResponder; | |||
| [self.scrollView.subviews makeObjectsPerformSelector:@selector(removeFromSuperview)]; | |||
| [self.scrollView.subviews enumerateObjectsUsingBlock:^(id obj, NSUInteger idx, BOOL *stop) { | |||
| if (obj == self.inputTextField) return; | |||
There was a problem hiding this comment.
Hey, thanks for the pull-request. Instead of early return, can it be:
if (obj != self.inputTextField) {
[obj removeFromSuperview];
}
|
That's a matter of style, of course. Feel free to use whichever coding style best fits the rest of the project. |
|
Any ETA on when this will be merged? I'd love to do a |
|
@rrossinvicara If you can make the style-change that I commented with that would be great. If getting this bug fixed is urgent, you can modify your pod 'VENTokenField', :git => 'https://github.com/rrossinvicara/VENTokenField.git' |
|
The style has been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...on iPad with soft keyboard active in landscape. This was caused by the input text field to lose its first responder status, and then requesting it immediately after.