Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acts: 21.1.0 -> 30.3.2, eicrecon: 1.5.1 -> 1.8.0 #105

Merged
merged 3 commits into from
Nov 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions flake.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

# define source repositories as flake inputs to enable overrides from CLI
inputs.acts-src = {
url = "github:acts-project/acts/v21.1.0";
url = "github:acts-project/acts/v30.3.2";
flake = false;
};
inputs.algorithms-src = {
Expand All @@ -34,7 +34,7 @@
flake = false;
};
inputs.eicrecon-src = {
url = "github:eic/EICrecon/v1.5.1";
url = "github:eic/EICrecon/v1.8.0";
flake = false;
};
inputs.jana2-src = {
Expand Down
12 changes: 11 additions & 1 deletion pkgs/acts/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,19 @@

stdenv.mkDerivation (self: with self; {
pname = "acts";
version = "21.1.0.${acts-src.shortRev or "dirty"}";
version = "30.3.2.${acts-src.shortRev or "dirty"}";

src = acts-src;

postPatch = ''
sed -i Core/include/Acts/Seeding/SeedFinderConfig.hpp -e '1i#include <vector>'
'' + lib.optionalString stdenv.isDarwin ''
substituteInPlace Core/include/Acts/Propagator/ConstrainedStep.hpp \
--replace "constexpr" ""
substituteInPlace Fatras/include/ActsFatras/EventData/Particle.hpp \
--replace "constexpr" ""
'';

nativeBuildInputs = [
cmake
];
Expand Down Expand Up @@ -44,6 +53,7 @@ stdenv.mkDerivation (self: with self; {
"-DACTS_USE_SYSTEM_EIGEN3=ON"
"-DACTS_USE_SYSTEM_NLOHMANN_JSON=ON"
"-DFETCHCONTENT_SOURCE_DIR_DFELIBS=${dfelibs}"
"-DPython_FIND_FRAMEWORK=NEVER" # fix for missing sandboxing on GitHub actions
];

meta = with lib; {
Expand Down
6 changes: 5 additions & 1 deletion pkgs/eicrecon/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ in

stdenv.mkDerivation rec {
pname = "EICrecon";
version = "1.5.1.${eicrecon-src.shortRev or "dirty"}";
version = "1.8.0.${eicrecon-src.shortRev or "dirty"}";

src = eicrecon-src;

Expand All @@ -47,6 +47,10 @@ stdenv.mkDerivation rec {
--replace 'std::dynamic_pointer_cast' 'std::static_pointer_cast'
substituteInPlace src/algorithms/tracking/IterativeVertexFinder.cc \
--replace 'std::dynamic_pointer_cast' 'std::static_pointer_cast'

substituteInPlace cmake/jana_plugin.cmake \
--replace 'libActsExamplesFramework.so' \
'${"$"}{CMAKE_SHARED_LIBRARY_PREFIX}ActsExamplesFramework${"$"}{CMAKE_SHARED_LIBRARY_SUFFIX}'
'';

nativeBuildInputs = [
Expand Down
3 changes: 2 additions & 1 deletion pkgs/fun4all/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,8 @@ let
hash = "sha256-8TYw6XZfSmJ1v1WlMI2eY8t/fO5+exPwM999qziPa6Q=";
};

postPatch = ":";

buildInputs = [
boost
tbb
Expand All @@ -159,7 +161,6 @@ let
];

cmakeFlags = prev.cmakeFlags ++ [
"-DACTS_BUILD_EXAMPLES=ON"
"-DACTS_BUILD_PLUGIN_DD4HEP=OFF"
];
});
Expand Down
12 changes: 7 additions & 5 deletions pkgs/juggler/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,20 @@

stdenv.mkDerivation rec {
pname = "juggler";
version = "10.1.0";
version = "11.0.0";

src = fetchFromGitHub {
owner = "eic";
repo = pname;
rev = "v${version}";
hash = "sha256-HeLOQAsR7xgn2dfkTGBVf5EYgbfpa5yz/8K5PheKHRY=";
hash = "sha256-OzVRVirSVQIn9xuQTo2Gk4nqI1geBiojUow2PDJvCrs=";
};

patches = [
./podio_00_17.patch
];
postPatch = ''
substituteInPlace JugTrack/CMakeLists.txt \
--replace 'libActsExamplesFramework.so' \
'${"$"}{CMAKE_SHARED_LIBRARY_PREFIX}ActsExamplesFramework${"$"}{CMAKE_SHARED_LIBRARY_SUFFIX}'
'';

nativeBuildInputs = [
cmake
Expand Down
48 changes: 0 additions & 48 deletions pkgs/juggler/podio_00_17.patch

This file was deleted.

Loading