Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: text-shadow #555

Merged
merged 8 commits into from
Oct 6, 2023
Merged

fix: text-shadow #555

merged 8 commits into from
Oct 6, 2023

Conversation

LuciNyan
Copy link
Contributor

@LuciNyan LuciNyan commented Sep 27, 2023 •
edited
Loading

Description

  • Fix text-shadow.
  • Refactor the text to improve readability. Since the refactoring changes may be extensive, to prevent bugs caused by refactoring from being hard to locate, it will be implemented in multiple PRs step-by-step.

@vercel
Copy link

vercel bot commented Sep 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
satori-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2023 3:53pm

orca-security-us[bot]
orca-security-us bot reviewed Sep 27, 2023
View reviewed changes
Copy link

@orca-security-us orca-security-us bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@LuciNyan LuciNyan changed the title [WIP]refactor: text refactor: text Sep 27, 2023
@LuciNyan LuciNyan changed the title refactor: text fix: text-shadow Sep 29, 2023
@LuciNyan LuciNyan changed the title fix: text-shadow refactor: text Sep 29, 2023
@LuciNyan LuciNyan marked this pull request as ready for review September 29, 2023 05:40
@Jackie1210
Copy link
Contributor

Great! Could you add a test on the issue of text-shadow?

@LuciNyan
Copy link
Contributor Author

Great! Could you add a test on the issue of text-shadow?

Sure! Thanks for your suggestion!

Jackie1210
Jackie1210 reviewed Sep 30, 2023
View reviewed changes
src/handler/expand.ts Outdated Show resolved Hide resolved
src/text/index.ts Outdated Show resolved Hide resolved
@LuciNyan LuciNyan changed the title refactor: text fix: text-shadow Sep 30, 2023
@LuciNyan LuciNyan mentioned this pull request Oct 1, 2023
Merged
shuding
shuding approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@shuding shuding merged commit 461b0ef into vercel:main Oct 6, 2023
10 checks passed
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

🎉 This PR is included in version 0.10.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

sahithyandev pushed a commit to sahithyandev/satori that referenced this pull request Apr 26, 2024
@LuciNyan @sahithyandev
fix: text-shadow (vercel#555)
00edb11 
### Description
- Fix text-shadow.
- Refactor the **text** to improve readability. Since the refactoring
changes may be extensive, to prevent bugs caused by refactoring from
being hard to locate, it will be implemented in multiple PRs
step-by-step.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orca-security-us orca-security-us[bot] orca-security-us[bot] left review comments

@shuding shuding shuding approved these changes

@Jackie1210 Jackie1210 Jackie1210 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuciNyan @Jackie1210 @shuding