Skip to content

Commit

Permalink
Merge pull request #71 from veritrans/minor-logo-update-and-asset-cle…
Browse files Browse the repository at this point in the history
…anup

v2.32.1 Minor logo update and asset cleanup
  • Loading branch information
rizdaprasetya authored Feb 8, 2022
2 parents 6f142cf + c0be60d commit 3736a7c
Show file tree
Hide file tree
Showing 11 changed files with 15 additions and 3,665 deletions.
5 changes: 2 additions & 3 deletions MAINTAINING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,10 @@
- /class: the concrete class implementations for each of
- /midtrans-gateway.php: refer to that file comments.
- /lib: Midtrans API PHP library, commited dependency, need be manually updated to latest Midtrans PHP library on github/composer
- /js: folder for JS file asset on PG config page on WP admin panel
- /public: public asset folder for images, css, js on customer facing UI
- /public: public asset folder for images, css, js on user facing UI
- /images/payment-methods: folder of payment method icons
- all image directly used should not be prefixed with `alt_`
- if filename is prefixed with `alt_`, it is not directly used, and only there as alternative image.
- /resources: like library or helper folder, which may no longer be used? @TODO: remove this?
- /readme: required file, act as WP plugin manifest, see [this reference](https://wordpress.org/plugins/readme.txt).

Other:
Expand Down Expand Up @@ -92,6 +90,7 @@ Plugin WP Hosted url: https://wordpress.org/plugins/midtrans-woocommerce/
- `Stable tag:` {latest/stable version of this plugin (must have its own /trunk folder): x.x.x}
- Copy contents of Github root folder `Snap-Woocommerce` into your SVN folder, under `/trunk` folder
- Create new folder under `/tags` folder, name it with the plugin version. e.g: `2.6.3`
- or alternatively, better use [SVN command to do it](https://developer.wordpress.org/plugins/wordpress-org/how-to-use-subversion/#create-tags-from-trunk) by running script `svn copy /trunk /tags/2.6.3`. SVN will copy the trunk folder into new version tag folder.
- Ensure `Stable tag` value within `readme.txt` in folder `trunk` have the same value as above e.g: `2.6.3`
- values that need to be consistent:
- stable tag in readme.txt `/trunk`
Expand Down
2 changes: 1 addition & 1 deletion abstract/abstract.midtrans-gateway.php
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public function __construct() {
* Add JS script file to admin page
*/
public function midtrans_admin_scripts() {
wp_enqueue_script( 'admin-midtrans', MIDTRANS_PLUGIN_DIR_URL . 'js/admin-scripts.js' );
wp_enqueue_script( 'admin-midtrans', MIDTRANS_PLUGIN_DIR_URL . 'public/js/midtrans-admin-page.js' );
}

/**
Expand Down
2 changes: 0 additions & 2 deletions js/index.php

This file was deleted.

3,403 changes: 0 additions & 3,403 deletions lib/midtrans/data/cacert.pem

This file was deleted.

4 changes: 2 additions & 2 deletions midtrans-gateway.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
Plugin Name: Midtrans - WooCommerce Payment Gateway
Plugin URI: https://github.com/veritrans/SNAP-Woocommerce
Description: Accept all payment directly on your WooCommerce site in a seamless and secure checkout environment with <a target="_blank" href="https://midtrans.com/">Midtrans</a>
Version: 2.32.0
Version: 2.32.1
Author: Midtrans
Author URI: http://midtrans.co.id
License: GPLv2 or later
WC requires at least: 2.0.0
WC tested up to: 5.7
WC tested up to: 6.1
*/

/*
Expand Down
Binary file modified public/images/payment-methods/alfamart.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified public/images/payment-methods/alt_alfamart_3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes.
12 changes: 10 additions & 2 deletions readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
Contributors: yocki, rizdaprasetya
Tags: midtrans, snap, payment, payment-gateway, credit-card, commerce, e-commerce, woocommerce, veritrans
Requires at least: 3.9.1
Tested up to: 5.8
Stable tag: 2.32.0
Tested up to: 5.9
Stable tag: 2.32.1
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html

Expand Down Expand Up @@ -72,6 +72,10 @@ The best way please email to support@midtrans.com, but bugs can be reported in o

== Changelog ==

= 2.32.1 - 2021-02-08 =
* minor plugin size reduction by removing unused assets
* update payment icon logo for brimo & dandan with current version

= 2.32.0 - 2021-09-22 =
* improve payment icon visual: add semi transparet background & border for better compatibility with dark color theme, prevent image stretched on some themes, add spacing
* improve notif handler to allow retry of 'expire' card payment (abandoned on 3DS step)
Expand Down Expand Up @@ -270,6 +274,10 @@ The best way please email to support@midtrans.com, but bugs can be reported in o

== Upgrade Notice ==

= 2.32.1 - 2021-02-08 =
* minor plugin size reduction by removing unused assets
* update payment icon logo for brimo & dandan with current version

= 2.32.0 - 2021-09-22 =
* improve payment icon visual: add semi transparet background & border for better compatibility with dark color theme, prevent image stretched on some themes, add spacing
* improve notif handler to allow retry of 'expire' card payment (abandoned on 3DS step)
Expand Down
250 changes: 0 additions & 250 deletions resources/countries.csv

This file was deleted.

2 changes: 0 additions & 2 deletions resources/index.php

This file was deleted.

0 comments on commit 3736a7c

Please sign in to comment.