Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Uncomment more worker ASAN tests #1427

Merged
merged 7 commits into from
Jul 18, 2024
Merged

CI: Uncomment more worker ASAN tests #1427

merged 7 commits into from
Jul 18, 2024

Conversation

ibc
Copy link
Member

@ibc ibc commented Jul 18, 2024 •
edited
Loading

Magically all ASAN things are working.

@jmillan
Copy link
Member

jmillan commented Jul 18, 2024

Seems like a bug in Ubuntu 20.04 with gcc https://github.com/orgs/community/discussions/63391

In the related issue it seems like manually installing libgcc-9-dev could fix it.

@ibc ibc mentioned this pull request Jul 18, 2024
Closed
@ibc ibc marked this pull request as ready for review July 18, 2024 11:51
@ibc
Copy link
Member Author

ibc commented Jul 18, 2024 •
edited
Loading

Unfortunately test-asan-thread still fails in Ubuntu 20.04 with libgcc-9-dev installed:

https://github.com/versatica/mediasoup/actions/runs/9992113733/job/27616379442?pr=1427

/usr/bin/ld: cannot find libtsan_preinit.o: No such file or directory

I'm now trying this:

@ibc
Copy link
Member Author

ibc commented Jul 18, 2024

ALL GREEN!

@ibc ibc merged commit 09810e9 into v3 Jul 18, 2024
41 checks passed
@ibc ibc deleted the ci-enable-more-worker-test-asan branch July 18, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibc @jmillan