add unit test for mapping packets with lower sequence number than the first mapped packet #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fippo
force-pushed
the
map-late-first
branch
5 times, most recently
from
7ed8abe
to
9a7c0c0
Compare
… first mapped packet see versatica#1437 and versatica#1438. Works but why not have a test
ibc
reviewed
Aug 6, 2024
| @@ -1400,4 +1400,19 @@ SCENARIO("SeqManager", "[rtc][SeqMananger]") | |||
| SeqManager<uint16_t> seqManager(/*initialOutput*/ 1000); | |||
| validate(seqManager, inputs); | |||
| } | |||
|
|
|||
| SECTION("map packets prior to first mapped packet") | |||
There was a problem hiding this comment.
I fail to see the value that this test adds to the already existing tests? Isn't this already tested in existing tests?
Also, what does "mapped packet" mean? We don't use that terminology anywhere in the source code and in existing tests.
There was a problem hiding this comment.
Not covered (or at least not explicitily), does backward wrap-around as a bonus. What terminology do you suggest?
ibc
added a commit
that referenced
this pull request
Aug 6, 2024
|
Thanks. I've added the corresponding tests in my ongoing PR to test the new feature: Let's close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1437 and #1438. Works but why not have a test