Test foo #1443
Closed
Test foo #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Details
- `createWorker({ disableLiburing: true })` disables LibUring usage despite it's supported by the worker and current host.
- Related (still to be fixed) issue which brings lot of context: #1435
Co-authored-by: Nazar Mokrynskyi <nazar@mokrynskyi.com>
This reverts commit 5ce4ff8.
This reverts commit 2893da0.
This reverts commit 53b68bc.
This reverts commit cc97c1a.
This reverts commit 975c5ac.
This reverts commit 80fbae0.
This reverts commit 0529246.
This reverts commit 0799e37.
|
You know you can test CI without opening PRs, right? |
Yes, but I may want to use this PR as temporal documentation. Well, tests will probably pass here which means that something in my PR broke things despite it looks incredible. |
Could use a more creative title in this case 🙈 |
|
Ok, Rust tests pass in this branch which is basically v3. So no magic here. Something is broken in #1442. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEST: DELETE
This is basically same as v3 branch. This branch comes from #1442 PR in which all its commits have been reverted. Just to see if Rust tests also fail here.