Use Json(Object|Array) directly instead of serializing to json twice #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dean Pehrsson-Chapman <dean@p14n.com>
…tx json objects Signed-off-by: Dean Pehrsson-Chapman <dean@p14n.com>
Signed-off-by: Dean Pehrsson-Chapman <dean@p14n.com>
|
Great, thanks! I built the 1.0.0.Beta3 release last night just before your PR, so I'll merge this in and try to put out a Beta4 next week. Apologies if I've already asked you do to this, but have you signed/can you sign the Eclipse CLA? I'll need that done before I can merge: http://www.eclipse.org/legal/CLA.php |
|
Cool, ta. |
|
I've merged this in, and cleaned up some of the functions a bit. I'm going to release a 1.0.0.RC1 with these changes today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now capable of encoding Datomic EntityMaps. Slight performance improvement from skipping the clojure.data.json step.
re: https://groups.google.com/forum/#!topic/vertx/OZhE0laA9I4