Add support for syn:user and syn:role to repr/norm by name #3959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3959 +/- ##
==========================================
- Coverage 96.38% 96.31% -0.07%
==========================================
Files 252 252
Lines 58499 58547 +48
==========================================
+ Hits 56382 56389 +7
- Misses 2117 2158 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
invisig0th
changed the title
Cisphyx
reviewed
Oct 18, 2024
Comment on lines
+267
to
+269
| # TODO convert getUserByName() and getRoleByName() | ||
| # back from async? These were plumbed to avoid infecting | ||
| # type norm/repr functions with async... |
There was a problem hiding this comment.
Yeah I think we should do that when the deprecated auth:ctor config option is removed, no reason for them to be async
Cisphyx
reviewed
Oct 18, 2024
Cisphyx
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.