From 50d15705b99a839349fceb5c531c881faa72603c Mon Sep 17 00:00:00 2001 From: Andrew Rosenberg <2112318+Iapetus999@users.noreply.github.com> Date: Tue, 20 Aug 2024 16:58:38 -0700 Subject: [PATCH] Fix digit check in `luhn.verify` (#528) * Fix digit check in `luhn.verify` * Fix digit check in `luhn.verify` * Fix digit check in `luhn.verify` --- larky/src/main/resources/vendor/luhn.star | 2 +- .../vendor_tests/luhn/{luhn_test.star => test_luhn.star} | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) rename larky/src/test/resources/vendor_tests/luhn/{luhn_test.star => test_luhn.star} (93%) diff --git a/larky/src/main/resources/vendor/luhn.star b/larky/src/main/resources/vendor/luhn.star index 13de6509..1964c132 100644 --- a/larky/src/main/resources/vendor/luhn.star +++ b/larky/src/main/resources/vendor/luhn.star @@ -21,7 +21,7 @@ def verify(num): >>> verify('534618613411236') False """ - if not isdigit(num): + if not num.isdigit(): return False checksum = int(num[-1]) cardSum = int(_luhn_summation(num,-2)) diff --git a/larky/src/test/resources/vendor_tests/luhn/luhn_test.star b/larky/src/test/resources/vendor_tests/luhn/test_luhn.star similarity index 93% rename from larky/src/test/resources/vendor_tests/luhn/luhn_test.star rename to larky/src/test/resources/vendor_tests/luhn/test_luhn.star index 94fa16fa..9d9bcf19 100644 --- a/larky/src/test/resources/vendor_tests/luhn/luhn_test.star +++ b/larky/src/test/resources/vendor_tests/luhn/test_luhn.star @@ -22,6 +22,7 @@ def _testsuite(): _suite.addTest(unittest.FunctionTestCase(test_valid)) _suite.addTest(unittest.FunctionTestCase(test_invalid)) _suite.addTest(unittest.FunctionTestCase(test_generate)) + _suite.addTest(unittest.FunctionTestCase(test_nonumeric)) _suite.addTest(unittest.FunctionTestCase(test_append)) return _suite