include Spright Parking benchmark (docker-compose local) #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lrq619 <lrq619@outlook.com>
ustiugov
requested changes
May 11, 2024
There was a problem hiding this comment.
- use git lfs for binary files
- Add copyrights to all source files
- update the Dependabot config of the repo
- Remove the compiled server binary from git, add to gitignore
- Is knative setup tested or not? If not, we cannot merge this code before it is done
- I do not see any CI tests, cannot merge as is
|
|
||
|
|
||
| ## Running this benchmark (using knative) | ||
| ### TODO: Need to test it on knative |
There was a problem hiding this comment.
Done? Open issue if cannot be done by next week
|
|
||
| ## Running this benchmark (using knative) | ||
| ### TODO: Need to test it on knative | ||
| Below contents haven't been tested on knative |
There was a problem hiding this comment.
This is not acceptable for the code to be merged
| access_log /var/log/nginx/access.log main; | ||
|
|
||
| sendfile on; | ||
| #tcp_nopush on; |
There was a problem hiding this comment.
Clean up commented code here and below
| COPY default.conf /etc/nginx/conf.d/default.conf | ||
| COPY nginx_setup.sh ./setup/nginx_setup.sh | ||
|
|
||
| # COPY sprightparking.crt /etc/ssl/cert/sprightparking.crt |
| access_log /var/log/nginx/access.log main; | ||
|
|
||
| sendfile on; | ||
| #tcp_nopush on; |
| stream.write(input_data) | ||
| stream.close() | ||
|
|
||
| # ingressIP = subprocess.check_output("docker inspect parking-proxy -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' ", shell=True).decode('UTF-8') |
| @@ -0,0 +1,10 @@ | |||
| grpcio==1.45.0 | |||
There was a problem hiding this comment.
Don't forget to update the Dependabot config of the repo
| template: | ||
| metadata: | ||
| annotations: | ||
| # autoscaling.knative.dev/minScale: "1" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the spright parking benchmark requires
the relevant deployment is contained in dc-parking.yaml
The nginx server is built by a docker image with relevant config file in spright-parking/docker/nginx-local. This is to facilate the allocation of ip address.
The function chain ip is allocated statically instead of dynamically, as config cannot be updated on runtime, compared to the original knative method of deploying with an istio service mesh handling the networking portion.