Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non system cursors are not adapted to DPI scale changes #104

Open
akoch-yatta opened this issue Jul 19, 2024 · 2 comments
Open

Non system cursors are not adapted to DPI scale changes #104

akoch-yatta opened this issue Jul 19, 2024 · 2 comments
Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT

Comments

@akoch-yatta
Copy link

akoch-yatta commented Jul 19, 2024

For system cursors windows has them autoscaled to the DPI it is used on. That does not work when cursors are created by the Constructors with ImageData provided to them.
One solution here could be to apply the "one cursor handle per zoom"-pattern as it is done in the other resources. But with ImageData as data source this would result in a pixelated scaling. Better would probably be to provide one or more additional constructors with ImageDataProvider and/or ImageFileNameProvider instead of ImageData to be able to properly fetch scaled variants of a cursor.

@akoch-yatta akoch-yatta added SWT Issue for SWT HiDPI A HiDPI-Related Issue or Feature Enhancement A Request for an Enhancement of an Existing Feature labels Jul 19, 2024
@akoch-yatta akoch-yatta changed the title Apply handle by zoom pattern to Cursors as well Non system cursors are not adapted to DPI scale changes Jul 19, 2024
@ShahzaibIbrahim
Copy link

@fedejeanne I see a PR being merged for this one. Should we close this here?

@HeikoKlare
Copy link
Contributor

Which PR do you refer to? The one referring to this issue (eclipse/gef-classic#479, even though the link has been removed), is specific to GEF and and is not a solution for this issue in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A Request for an Enhancement of an Existing Feature HiDPI A HiDPI-Related Issue or Feature SWT Issue for SWT
Projects
Status: 🔖 Ready: Atomic
Development

No branches or pull requests

3 participants