Skip to content

Commit

Permalink
comments
Browse files Browse the repository at this point in the history
  • Loading branch information
nicksanford committed Jul 5, 2023
1 parent a1e80dc commit c3ffe4a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
5 changes: 4 additions & 1 deletion cartofacade/capi_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,10 @@ func TestCGoAPI(t *testing.T) {
test.That(t, position.Kmag, test.ShouldNotEqual, 0)
test.That(t, position.Real, test.ShouldNotEqual, 1)

// test getPointCloudMap returns different result than first second call
// test getPointCloudMap returns non 0 response
// on aarm64 linux this always returns a different response
// but on aar64 osx it returns the same map for some reason
// https://viam.atlassian.net/browse/RSDK-3866
pcd, err = vc.getPointCloudMap()
test.That(t, err, test.ShouldBeNil)
test.That(t, pcd, test.ShouldNotBeNil)
Expand Down
5 changes: 3 additions & 2 deletions viam-cartographer/src/carto_facade/carto_facade_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -804,8 +804,9 @@ BOOST_AUTO_TEST_CASE(CartoFacade_demo) {
viam_carto_get_internal_state_response isr;
BOOST_TEST(viam_carto_get_internal_state(vc, &isr) ==
VIAM_CARTO_SUCCESS);
// on linux this is strictly greater than but on mac
// for some reason it is only equal to.
// on aarm64 linux this is strictly greater than
// on aarm64 mac for some reason it is equal to
// https://viam.atlassian.net/browse/RSDK-3866
BOOST_TEST(blength(isr.internal_state) >=
last_internal_state_response_size);
last_internal_state_response_size = blength(isr.internal_state);
Expand Down

0 comments on commit c3ffe4a

Please sign in to comment.