RSDK-3324 - Refactor carto_grpc_server to move initialization into IO-bound and non-IO-bound functions #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
|
Removing myself from the review since Nick will review (feel free to leave me off for project PR's!) |
nicksanford
reviewed
Jun 1, 2023
| @@ -37,7 +37,7 @@ DEFINE_bool(use_live_data, false, | |||
| DEFINE_bool(aix_auto_update, false, "Automatically updates the app image"); | |||
|
|
|||
| void ParseAndValidateConfigParams(int argc, char** argv, | |||
| SLAMServiceImpl& slamService) { | |||
| SLAMServiceImpl* slamService) { | |||
There was a problem hiding this comment.
Why did this function need to change?
There was a problem hiding this comment.
Great question - I realize I didn't need to make this change after all. Reverted it.
| @@ -141,55 +141,55 @@ void ParseAndValidateConfigParams(int argc, char** argv, | |||
| OverwriteCartoConfigParam(slamService, carto_param); | |||
| } | |||
|
|
|||
| void OverwriteCartoConfigParam(SLAMServiceImpl& slamService, | |||
| void OverwriteCartoConfigParam(SLAMServiceImpl* slamService, | |||
There was a problem hiding this comment.
Why did this function need to change?
There was a problem hiding this comment.
Great question - I realize I didn't need to make this change after all. Reverted it.
viambot
added
safe to test
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://viam.atlassian.net/browse/RSDK-3324
Done:
SLAMServiceImpl::Init(...)SLAMServiceImpl::Start()