-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-3786] full-mod-new-close #186
Merged
nicksanford
merged 32 commits into
viam-modules:main
from
nicksanford:RSDK-3547-use-cgo-api-methods2
Jul 11, 2023
Merged
[RSDK-3786] full-mod-new-close #186
nicksanford
merged 32 commits into
viam-modules:main
from
nicksanford:RSDK-3547-use-cgo-api-methods2
Jul 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
This pull request is marked safe to test from a trusted zone
label
Jul 7, 2023
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jul 7, 2023
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jul 7, 2023
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jul 7, 2023
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jul 7, 2023
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jul 7, 2023
nicksanford
commented
Jul 7, 2023
nicksanford
commented
Jul 7, 2023
nicksanford
commented
Jul 7, 2023
nicksanford
commented
Jul 7, 2023
nicksanford
commented
Jul 7, 2023
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jul 10, 2023
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jul 10, 2023
Co-authored-by: kim-mishra <121991867+kim-mishra@users.noreply.github.com>
Co-authored-by: kim-mishra <121991867+kim-mishra@users.noreply.github.com>
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jul 11, 2023
Co-authored-by: kim-mishra <121991867+kim-mishra@users.noreply.github.com>
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jul 11, 2023
Co-authored-by: kim-mishra <121991867+kim-mishra@users.noreply.github.com>
viambot
removed
the
safe to test
This pull request is marked safe to test from a trusted zone
label
Jul 11, 2023
Co-authored-by: kim-mishra <121991867+kim-mishra@users.noreply.github.com>
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jul 11, 2023
kim-mishra
reviewed
Jul 11, 2023
Co-authored-by: kim-mishra <121991867+kim-mishra@users.noreply.github.com>
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jul 11, 2023
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jul 11, 2023
kim-mishra
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jul 11, 2023
This was referenced Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
viamcartographer.New
initialize 1.) a carto facade instance 2.) a background go routine which will call into the carto facade C code 3.) a sensor process go routine to add sensor data when the full mod feature flag is enabledviamcartographer.Close
terminate in the proper order the resources initialized byviamcartographer.New
build
target to compile the C++ code (if not already compiled) before compiling the go code. This is needed as now main.go needs to link in C code, which was not the case prior. W/o this change, it doesn't build.