add jobs done file #191
add jobs done file #191
Conversation
viambot
added
the
safe to test
JohnN193
added
appimage
JohnN193
requested review from
EshaMaharishi
and removed request for
EshaMaharishi
JohnN193
added
appimage-ignore-tests
viambot
added
the
safe to test
viam-cartographer.go
Outdated
| if err != nil { | ||
| cartoSvc.logger.Warn(err) | ||
| } | ||
| jobsDone = true |
There was a problem hiding this comment.
- Could we talk about the requirements for this feature so I can be sure that it gets rolled into full mod?
- I don't think it works to track a given session completing at the package level, as variable is shared across viam cartographer instances & persists even after reconfiguration.
- I recommend instead (assuming this should be scoped to a given viam cartographer instance & should be reset on restart) to put it on thecartographerService struct.
- Also, should Jobs_Done.txt still persist if cartographer is reconfigured?
cc @EshaMaharishi
There was a problem hiding this comment.
It doesn't matter if the jobs done file persists after cartographer is reconfigured since a cloud slam session will only be configured once, but I agree for code cleanliness it's better to scope it to a single configuration
There was a problem hiding this comment.
moved the flag into the cartographerService struct, but I did not handle removing the file on reconfig as that is unnecessary for the demo & usage with a replay camera, but I included it in the followup ticket for the file
There was a problem hiding this comment.
followed up offline, in the followup ticket we will switch to using a DoCommand
|
would need to do some looking to see if we have access to cartographer's queue, to see if all data has been processed, but I can make a ticket for that |
|
https://viam.atlassian.net/browse/RSDK-3980 ticket to move the job creation file |
viambot
added
safe to test
adds a jobs done file when the replay camera stops. additionally prevents cartographer from repeating the warning about the job being completed.
Additional issue is this file gets created when all lidar scans are read into the job, but this does not mean that all lidar scans have been processed
unsure of interactions with full mod and interactions with a live replay camera