fix-makefile-not-rebuilding-cartographer-module #203
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
make build
not rebuilding cartographer-module if it has been built before.Now
make build
always rebuilds the cartographer-module go binary.Follows the same pattern as: viam-server's
make server
make target: https://github.com/viamrobotics/rdk/blob/main/Makefile#L81I accidentally introduced this bug in the build system in #186