Reduce Appimage Size #309
Reduce Appimage Size #309
Conversation
viambot
added
the
safe to test
| - sourceline: deb [trusted=yes] http://deb.debian.org/debian-security bullseye-security main | ||
| - sourceline: deb [trusted=yes] http://deb.debian.org/debian bullseye-updates main | ||
| - sourceline: deb [trusted=yes] https://us-apt.pkg.dev/projects/static-file-server-310021 bullseye main | ||
| - sourceline: deb [trusted=yes] http://deb.debian.org/debian bookworm main |
There was a problem hiding this comment.
[note] Upgrading to bookworm to use non-dev packages which are smaller and unavailable in bullseye. This upgrade also matches the new red-env used in workflows. Appimage will be backward compatible to bullseye
viambot
added
safe to test
| - libgl1:arm64 | ||
| - libglvnd0:arm64 | ||
| - libnlopt0:arm64 | ||
| - libabsl20220623 |
There was a problem hiding this comment.
out of scope for review, but you can probably use a single appimage yml for both platforms
they support environment variable in these, with ${VAR} syntax I believe, and the diff between these files seems fairly small now
(totally optional, only if it matters to you)
There was a problem hiding this comment.
We'll handle this in the future, when a larger overhaul of the system occurs
.github/workflows/deploy_module.yml
Outdated
| image: ghcr.io/viamrobotics/canon:amd64-cache | ||
| platform: amd64 | ||
| image: ghcr.io/viamrobotics/rdk-devenv:amd64-cache | ||
| platform: linux/amd64 |
There was a problem hiding this comment.
this may fail when you run it -- this is being consumed elsewhere in the file as matrix.platform, both here + in the upload job
There was a problem hiding this comment.
Made consistent with other workflows
viambot
added
safe to test
viambot
added
safe to test
Tested arm64 appiamge on bookworm pi