RSDK-6040 Add GetProperties endpoint to viam-cartographer #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
viambot
added
safe to test
jeremyrhyde
commented
Dec 26, 2023
go.mod
Outdated
| @@ -329,3 +329,5 @@ require ( | |||
| periph.io/x/conn/v3 v3.7.0 // indirect | |||
| periph.io/x/host/v3 v3.8.2 // indirect | |||
| ) | |||
|
|
|||
| replace go.viam.com/rdk => /Users/jeremyhyde/Development/rdk | |||
There was a problem hiding this comment.
[note] to be removed after viamrobotics/rdk#3376 and new rdk release
viambot
added
safe to test
kim-mishra
reviewed
Dec 26, 2023
viam_cartographer.go
Outdated
| @@ -678,3 +689,17 @@ func CheckQuaternionFromClientAlgo(pose spatialmath.Pose, componentReference str | |||
| } | |||
| return nil, "", errors.Errorf("error getting SLAM position: quaternion not given, %v", returnedExt) | |||
| } | |||
|
|
|||
| // checkCloseAndCloudStatus returns an error if the cartographer service has been previously closed or is being run in the cloud. | |||
| func (cartoSvc *CartographerService) checkCloseAndCloudStatus(cmd string) error { | |||
There was a problem hiding this comment.
Suggested change
| func (cartoSvc *CartographerService) checkCloseAndCloudStatus(cmd string) error { | |
| func (cartoSvc *CartographerService) isOpenAndRunningLocally(cmd string) error { |
There was a problem hiding this comment.
[nit] think a name starting with is might read a little cleaner in all of the functions it is used in
kim-mishra
reviewed
Dec 26, 2023
kim-mishra
approved these changes
Dec 26, 2023
Co-authored-by: kim-mishra <121991867+kim-mishra@users.noreply.github.com>
viambot
added
safe to test
viambot
added
safe to test
jeremyrhyde
changed the title
viambot
added
safe to test
jeremyrhyde
changed the title
viambot
added
safe to test
viambot
removed
the
safe to test
viambot
added
the
safe to test
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Properties for viam-cartographer.
Related PR: viamrobotics/rdk#3376
JIRA Ticket: https://viam.atlassian.net/browse/RSDK-6040