add missing include #312
Merged
add missing include #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnN193
added
the
appimage-ignore-tests
viambot
added
the
safe to test
viambot
added
safe to test
randhid
reviewed
Dec 29, 2023
| @@ -34,7 +34,7 @@ func (config *Config) StartOfflineSensorProcess(ctx context.Context) bool { | |||
| lidarReading, err := config.Lidar.TimedLidarReading(ctx) | |||
| if err != nil { | |||
| config.Logger.Warn(err) | |||
| return errors.Is(err, replaypcd.ErrEndOfDataset) | |||
| return strings.Contains(err.Error(), replaypcd.ErrEndOfDataset.Error()) | |||
There was a problem hiding this comment.
okay we should totally have the end of dataset logic be handled better, this is too brittle, I'm assuming it was sent over with an rpc wrapper and couldn't be compared using `errors.Is'? I wonder if we could have replay metadata be exposed somewhere.
randhid
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr fixes missing dependency in appimage and also fixes an issue where cloudslam would hang in offline mode after reaching the end of the dataset.
tested in cloudslam to see if job would run with appimage change.
job using latest: https://console.cloud.google.com/run/jobs/details/us-central1/cloudslam-job-658ef3c5418275aba713d91a/logs?project=staging-cloud-web-app
robot fails to connect.
job using pr: https://console.cloud.google.com/run/jobs/details/us-central1/cloudslam-job-658ef005418275aba712b26c/logs?project=staging-cloud-web-app
robot successfully connects