Remove GetLatestMapInfo from SLAM #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kim-mishra <121991867+kim-mishra@users.noreply.github.com>
viambot
added
the
safe to test
jeremyrhyde
changed the title
viambot
added
safe to test
kkufieta
approved these changes
Jan 22, 2024
go.mod
Outdated
Comment on lines
332
to
333
|
|
||
| replace go.viam.com/rdk => /Users/jeremyhyde/Development/rdk |
There was a problem hiding this comment.
Will remove after RDK release and before merge
testhelper/integrationtesthelper.go
Outdated
| @@ -116,19 +116,14 @@ func testCartographerPosition(t *testing.T, svc slam.Service, useIMU bool, expec | |||
|
|
|||
| // Checks the cartographer map and confirms there at least 100 map points. | |||
| func testCartographerMap(t *testing.T, svc slam.Service, localizationMode bool) { | |||
| timestamp1, err := svc.LatestMapInfo(context.Background()) | |||
| prop, err := svc.Properties(context.Background()) | |||
There was a problem hiding this comment.
[nit] Clearer to read
Suggested change
| prop, err := svc.Properties(context.Background()) | |
| props, err := svc.Properties(context.Background()) |
viambot
added
safe to test
JohnN193
approved these changes
Jan 22, 2024
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the GetLatestMapInfo endpoint from SLAM in viam-cartographer module.
JIRA Ticket: https://viam.atlassian.net/browse/RSDK-6133