RSDK-5334 - Remove unused code #317
Conversation
viambot
added
safe to test
viambot
added
safe to test
kkufieta
force-pushed
the
kk/rsdk-5334-remove-unused-code
branch
from
e6f1cd9
to
fe403c4
Compare
viambot
added
safe to test
kkufieta
changed the title
| std::string filename = | ||
| "temp_internal_state_" + boost::uuids::to_string(uuid) + ".pbstream"; |
There was a problem hiding this comment.
should this be in a tmp dir?
There was a problem hiding this comment.
Good point - I think so. @JohnN193 can you take a look and confirm?
There was a problem hiding this comment.
i think having a temp dir just adds more for us to cleanup, but if its better practice to use one then thats fine with me!
There was a problem hiding this comment.
I think it is better practice - for linux machines anything in that directory will get cleaned up during boot according to https://linuxhandbook.com/tmp-directory/amp/
This would at least protect us on some machines in the case of a crash before cleanup
| @@ -28,6 +28,7 @@ const SensorId kOdometerSensorId{SensorId::SensorType::ODOMETRY, "odometry"}; | |||
|
|
|||
| class MapBuilder { | |||
| public: | |||
| MapBuilder() : trajectory_builder(){}; | |||
There was a problem hiding this comment.
[q] what does adding this here do?
There was a problem hiding this comment.
The valgrind test was complaining that trajectory_builder was not initialized but used in an if-statement (Conditional jump or move depends on uninitialised value(s)), which happens when we error out here.
This change initializes trajectory_builder to nullptr and fixes the issue.
viambot
added
safe to test
viambot
added
safe to test
Ticket: https://viam.atlassian.net/browse/RSDK-5334
Done:
data_dir,cloud_story_enabled,map_rate_secTested on: