Add codec enum handlers

viam-modules · Sep 5, 2024 · e114a23 · e114a23
1 parent a8fc69a
commit e114a23
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 3 deletions.
diff --git a/cam/cam.go b/cam/cam.go
@@ -24,7 +24,7 @@ const (
 	// Default values for the video storage camera component.
 	defaultSegmentSeconds = 30 // seconds
 	defaultStorageSize    = 10 // GB
-	defaultVideoCodec     = "h264"
+	defaultVideoCodec     = CodecH264
 	defaultVideoBitrate   = 1000000
 	defaultVideoPreset    = "medium"
 	defaultVideoFormat    = "mp4"
@@ -129,8 +129,8 @@ func newvideostore(
 
 	// Create encoder to handle encoding of frames.
 	// TODO(seanp): Forcing h264 for now until h265 is supported.
-	if newConf.Video.Codec != "h264" {
-		newConf.Video.Codec = defaultVideoCodec
+	if ParseCodecType(newConf.Video.Codec) != CodecH264 {
+		newConf.Video.Codec = defaultVideoCodec.String()
 	}
 	if newConf.Video.Bitrate == 0 {
 		newConf.Video.Bitrate = defaultVideoBitrate

diff --git a/cam/utils.go b/cam/utils.go
@@ -19,6 +19,36 @@ import (
 	"time"
 )
 
+type CodecType int
+
+const (
+	CodecUnknown CodecType = iota
+	CodecH264
+	CodecH265
+)
+
+func (c CodecType) String() string {
+	switch c {
+	case CodecH264:
+		return "h264"
+	case CodecH265:
+		return "h265"
+	default:
+		return "unknown"
+	}
+}
+
+func ParseCodecType(codec string) CodecType {
+	switch codec {
+	case "h264":
+		return CodecH264
+	case "h265":
+		return CodecH265
+	default:
+		return CodecUnknown
+	}
+}
+
 // ffmpegError returns a string representation of the ffmpeg error code.
 func ffmpegError(ret C.int) string {
 	var errbuf [256]C.char