[RSDK-8760] - README improvements #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanavery
requested review from
randhid and
hexbabe
and removed request for
randhid
hexbabe
reviewed
Oct 8, 2024
Cutting release once this PR is in.
Probably a good idea! |
seanavery
changed the title
sguequierre
reviewed
Oct 8, 2024
README.md
Outdated
| ] | ||
| } | ||
| ``` | ||
|
|
||
| Make sure to configure a [Data Manager Service](https://docs.viam.com/services/data/cloud-sync/) to uplaod video files to the cloud. | ||
| ### Configure a Data Manager Service |
There was a problem hiding this comment.
Would suggest moving this up to above configure a video-store section in a section called ## Requirements and also adding the instructions to configure through the UI:
Navigate to the [**CONFIGURE** tab](https://docs.viam.com/configure/) of your [machine](https://docs.viam.com/fleet/machines/) in [the Viam app](https://app.viam.com/). [Add data-management to your machine](https://docs.viam.com/configure/#services).
There was a problem hiding this comment.
Added requirements section.
Co-authored-by: Sierra Guequierre <sguequierre@gmail.com>
Co-authored-by: Sierra Guequierre <sguequierre@gmail.com>
Co-authored-by: Sierra Guequierre <sguequierre@gmail.com>
Co-authored-by: Sierra Guequierre <sguequierre@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description