Fix dynamic logic for ICE stats (#239)

viamrobotics · Jul 3, 2024 · bc59042 · bc59042
1 parent d6ca6f2
commit bc59042
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/linkcheck.yml b/.github/workflows/linkcheck.yml
@@ -27,7 +27,7 @@ jobs:
       - name: Test HTML
         # https://github.com/wjdp/htmltest-action/
         # Don't fail the build on broken links
-        continue-on-error: false
+        continue-on-error: true
         uses: wjdp/htmltest-action@master
         with:
           config: .htmltest.yml

diff --git a/lib/src/rpc/dial.dart b/lib/src/rpc/dial.dart
@@ -234,11 +234,11 @@ Future _logConnectionStats(Stopwatch webrtcDialSW, RTCPeerConnection peerConnect
     if (stat.type == 'candidate-pair' && stat.values['nominated']) {
       // Use 'lastPacketSentTimestamp' on candidate pair to estimate when the
       // pair was nominated.
-      final double lpst = stat.values['lastPacketSentTimestamp'];
+      final double lpst = stat.values['lastPacketSentTimestamp'] ?? 0;
       final DateTime nominatedTime = DateTime.fromMillisecondsSinceEpoch(lpst.toInt());
 
-      final String lcid = stat.values['localCandidateId'];
-      final String rcid = stat.values['remoteCandidateId'];
+      final lcid = stat.values['localCandidateId'];
+      final rcid = stat.values['remoteCandidateId'];
       for (var innerStat in stats) {
         if (innerStat.id == lcid) {
           final type = innerStat.values['candidateType'];