RSDK-8812: Add frame_rate to flutter sdk #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckras
changed the title
njooma
requested changes
Sep 25, 2024
Comment on lines
54
to
61
| return GetPropertiesResponse() | ||
| final response = GetPropertiesResponse() | ||
| ..supportsPcd = properties.supportsPcd | ||
| ..intrinsicParameters = properties.intrinsicParameters | ||
| ..distortionParameters = properties.distortionParameters; | ||
| if (properties.frameRate != 0) { | ||
| response.frameRate = properties.frameRate; | ||
| } | ||
| return response; |
There was a problem hiding this comment.
All of these can actually be deleted and all you have to do is return properties, since properties is a typealias for GetPropertiesResponse.
njooma
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frame_rateby returning it in getProperties in service.dartframe_rate