hotfix/release process #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the release process to use
environments. What are environments? Well they are a way to deploy code with protections and customizable secrets. That way, we could have different secrets for different deployments (e.g. a test or internal package repository for RC deployments, vs a public package repo for production deployments).It also means we can get rid of some janky steps in the workflow. Anyone can now run the action, but people from our team need to approve it. This makes it more like PRs, where people can request deployments and we approve them.
It's also a lot safer -- both pypi and pub.dev allow for restricting deployments only from specific environments