This repository has been archived by the owner on Oct 8, 2023. It is now read-only.
wait_server_available method ... #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the socket.socket() initialization to be inside the while loop. Having it outside initiates it only once and when closed inside the while loop, it starts to raise 'Bad File Descriptor' error since the socket is closed.
songww
reviewed
Sep 20, 2018
| @@ -131,9 +131,12 @@ def wait_server_available(host: str, port: int, timeout: int=10) -> None: | |||
| :param port: TCP port used to connect. | |||
| :return: | |||
| """ | |||
| sock = socket.socket() | |||
| sock.settimeout(timeout) | |||
| while timeout > 0: | |||
There was a problem hiding this comment.
The sockwill be undefined, if arg timeoutis less than 0 when func is calling.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the socket.socket() initialization to be inside the while loop. Having it outside initiates it only once and when closed inside the while loop, it starts to raise 'Bad File Descriptor' error since the socket is closed.
Before submitting a pull request, please make sure the following is done:
Fork the repository and create your branch from master.
Run the build.py and test.py scripts.
If you are fixing something, add tests that fail in the current version and pass in yours.
If you're developing a new feature open an issue first to discuss it. Some features may be useful to you but harmful to others be it because of performance, new dependencies or different perspectives.
One more time: Don't forget to add tests.
Ensure the entire test suite is passing and overall performance is not degraded.