Skip to content
This repository has been archived by the owner on Oct 8, 2023. It is now read-only.

Packaging scripts #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Packaging scripts #85

wants to merge 1 commit into from

Conversation

pyx
Copy link
Contributor

@pyx pyx commented Jun 26, 2018

Close #73 .

Proof of concept.
No ready to be merged right now

  • use 'extras_require' for optional dependencies in setup.py
  • CI might fail, 'uvloop' and 'ujson' is truly optional now.
  • Makfile
  • Easier way to setup development environment
  • pytest?

@pyx
Copy link
Contributor Author

pyx commented Jun 26, 2018

I am using this trick to reduce duplication:

In 'setup.py', list all requirements, including pinned version if necessary.
In requirements files, using what's defined in 'setup.py'.

Example:
setup.py with all dependencies, some with pinned versions.
https://github.com/pyx/hymn/blob/master/setup.py

DRY in requirements files
https://github.com/pyx/hymn/blob/master/requirements/core.txt
Can be as simple as a oneliner: -e .
Using '-e' here because if users install vibora from local repository, chances are, they want it to be editable as well.

This style is opinionated, so I am not pushing this right now.

@frnkvieira
Copy link
Member

I like the idea, let's push this forward

@pyx
Copy link
Contributor Author

pyx commented Jun 29, 2018

Okay, I will see if I can make any progress over weekend.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants