Merge pull request #48 from vicolo-dev/fix-theme_duplicate-scroll

Fix screen scrolling to top when duplicating a theme
vicolo-dev · Dec 17, 2023 · bf148b9 · bf148b9
2 parents f518b35 + 2465a8e
commit bf148b9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/android/app/build.gradle b/android/app/build.gradle
@@ -134,7 +134,7 @@ android {
       dev {
         dimension "app"
         resValue "string", "app_name","Chrono Dev"
-        versionNameSuffix "-dev",
+        // versionNameSuffix "-dev",
         applicationIdSuffix ".free"
       }
     }

diff --git a/lib/common/widgets/list/custom_list_view.dart b/lib/common/widgets/list/custom_list_view.dart
@@ -165,6 +165,8 @@ class _CustomListViewState<Item extends ListItem>
     // if (_scrollController.offset == 0) {
     //   _scrollController.jumpTo(1);
     // }
+    print(_controller.computeItemBox(0));
+    if (_itemCardHeight == 0) return;
     _scrollController.animateTo(index * _itemCardHeight,
         duration: const Duration(milliseconds: 250), curve: Curves.easeIn);
   }

diff --git a/lib/theme/widgets/theme_card.dart b/lib/theme/widgets/theme_card.dart
@@ -5,14 +5,14 @@ import 'package:flutter/material.dart';
 
 class ThemeCard<Item extends ThemeItem> extends StatelessWidget {
   const ThemeCard({
-    Key? key,
+    super.key,
     required this.themeItem,
     required this.onPressEdit,
     required this.isSelected,
     required this.getThemeFromItem,
     required this.onPressDelete,
     required this.onPressDuplicate,
-  }) : super(key: key);
+  });
 
   final Item themeItem;
   final VoidCallback onPressEdit;