Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weekly alarm schedule having inconsistent id #59

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

AhsanSarwar45
Copy link
Collaborator

@AhsanSarwar45 AhsanSarwar45 commented Dec 18, 2023

This caused it to display the following bugs when scheduled off:

  • Settings were not getting saved
  • Alarm couldn't be enabled
  • Alarm couldn't be deleted
  • Alarm couldn't be reordered

Fixes #54

@codecov-commenter
Copy link

Codecov Report

Attention: 121 lines in your changes are missing coverage. Please review.

Comparison is base (32b3af6) 31.44% compared to head (d4b9499) 31.34%.

Files Patch % Lines
lib/timer/types/timer.dart 0.00% 17 Missing ⚠️
lib/alarm/types/alarm.dart 0.00% 15 Missing ⚠️
lib/stopwatch/types/stopwatch.dart 0.00% 12 Missing ⚠️
...ib/alarm/types/schedules/dates_alarm_schedule.dart 0.00% 10 Missing ⚠️
lib/clock/types/city.dart 0.00% 9 Missing ⚠️
lib/stopwatch/types/lap.dart 0.00% 7 Missing ⚠️
...b/alarm/types/schedules/weekly_alarm_schedule.dart 75.00% 6 Missing ⚠️
lib/alarm/types/alarm_task.dart 0.00% 5 Missing ⚠️
lib/timer/types/timer_preset.dart 0.00% 5 Missing ⚠️
lib/alarm/logic/alarm_controls.dart 0.00% 4 Missing ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #59      +/-   ##
===========================================
- Coverage    31.44%   31.34%   -0.11%     
===========================================
  Files          212      212              
  Lines         7969     8015      +46     
===========================================
+ Hits          2506     2512       +6     
- Misses        5463     5503      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhsanSarwar45 AhsanSarwar45 merged commit ba5585c into develop Dec 18, 2023
3 checks passed
@AhsanSarwar45 AhsanSarwar45 added the bug Something isn't working label Dec 18, 2023
@AhsanSarwar45 AhsanSarwar45 deleted the fix-weekly-alarm-schedule branch December 21, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants