Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve timer notification screen #60

Merged
merged 10 commits into from
Dec 18, 2023

Conversation

AhsanSarwar45
Copy link
Collaborator

Closes #56

@codecov-commenter
Copy link

Codecov Report

Attention: 229 lines in your changes are missing coverage. Please review.

Comparison is base (c8dda74) 31.42% compared to head (a133523) 31.27%.

Files Patch % Lines
lib/timer/screens/timer_notification_screen.dart 0.00% 27 Missing ⚠️
lib/alarm/types/alarm.dart 5.55% 17 Missing ⚠️
lib/timer/types/timer.dart 0.00% 17 Missing ⚠️
lib/stopwatch/types/stopwatch.dart 0.00% 12 Missing ⚠️
lib/timer/widgets/timer_preset_card.dart 0.00% 12 Missing ⚠️
...ib/alarm/types/schedules/dates_alarm_schedule.dart 0.00% 10 Missing ⚠️
lib/timer/widgets/timer_picker.dart 0.00% 10 Missing ⚠️
lib/alarm/logic/alarm_controls.dart 0.00% 9 Missing ⚠️
lib/clock/types/city.dart 0.00% 9 Missing ⚠️
...lds/select_field/field_cards/audio_field_card.dart 0.00% 9 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   31.42%   31.27%   -0.15%     
==========================================
  Files         212      212              
  Lines        7966     8058      +92     
==========================================
+ Hits         2503     2520      +17     
- Misses       5463     5538      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhsanSarwar45 AhsanSarwar45 added the enhancement Improve existing features label Dec 18, 2023
@AhsanSarwar45 AhsanSarwar45 merged commit 60a521d into master Dec 18, 2023
3 checks passed
@AhsanSarwar45 AhsanSarwar45 deleted the enhancement-timer-notification-screen branch December 18, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add a better interface for timers
2 participants