feat: add support for com.fasterxml.jackson.annotation.JacksonAnnotationsInside annotation
#487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionsInside` helper annotation
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
|
@smaarn Thank you very much for the effort in creating this PR. I'm currently busy and unsure when I will get around to properly reviewing this, but I will soon. |
...odule-jackson/src/main/java/com/github/victools/jsonschema/module/jackson/JacksonHelper.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/github/victools/jsonschema/module/jackson/CustomEnumDefinitionProvider.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/github/victools/jsonschema/module/jackson/CustomEnumDefinitionProvider.java
Outdated
Show resolved
Hide resolved
...odule-jackson/src/main/java/com/github/victools/jsonschema/module/jackson/JacksonHelper.java
Outdated
Show resolved
Hide resolved
...e-jackson/src/test/java/com/github/victools/jsonschema/module/jackson/JacksonHelperTest.java
Outdated
Show resolved
Hide resolved
smaarn
changed the title
com.fasterxml.jackson.annotation.JacksonAnnotationsInside helper annotationcom.fasterxml.jackson.annotation.JacksonAnnotationsInside annotation
CarstenWickner
previously approved these changes
Oct 31, 2024
...le-jackson/src/main/java/com/github/victools/jsonschema/module/jackson/AnnotationHelper.java
Outdated
Show resolved
Hide resolved
…n the base package
…n the base package Remove no longer relevant comment
CarstenWickner
changed the base branch from
main
to
nested-jackson-annotations
CarstenWickner
merged commit a59c102
into
victools:nested-jackson-annotations
11 checks passed
smaarn
deleted the
feat/add-support-for-jackson-annotations-inside-annotation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the idea is to ensure that, for any annotation lookup, a fallback to use annotations injected via combo annotations is being used.
It turns out that there was already a mechanism to do that in
TypeContext(or*Contextinterfaces for what it's worth). There were other locations where it wasn't available so I implemented this manually in a dedicated helper class.Fixes #486